Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vote-2343 Static cards for military and overseas voters (FVAP.gov) #848

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jul 12, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2343

Description

Add hardcoded voter cards for military and overseas voters. Includes both English and Spanish.

Deployment and testing

Post-deploy steps

  1. build the theme
  2. lando retune

QA/Testing instructions

  1. On the homepage, verify both cards are added, with correct styling, and with the unique links for English and Spanish.
  2. Verify the cards show up on the voter guide pages.
  3. Verify the card group responsiveness still works correctly for mobile, tablet, and desktop.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat marked this pull request as ready for review July 12, 2024 18:52
@SamiraMSadat SamiraMSadat changed the title Vote 2343/static card military overseas Vote-2343 Static cards for military and overseas voters (FVAP.gov) Jul 12, 2024
@SamiraMSadat SamiraMSadat requested a review from rayestrada July 12, 2024 18:53
@rayestrada rayestrada merged commit 4d07687 into dev Jul 12, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2343/static-card-militay-overseas branch August 14, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants