Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2368: Fixed zoom-out issue for RTL pages. #852

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

WilliamYKwon
Copy link
Contributor

@WilliamYKwon WilliamYKwon commented Jul 15, 2024

Jira ticket

VOTE-2368

Description

Added overriding attributes (insets) for USWDS's 'sr-only' class to fix the zoom out issue for RTL langauges.

Deployment and testing

Post-deploy steps

  1. run 'npm run build' in custom theme.
  2. run 'lando retune'.

QA/Testing instructions

  1. load up the local site, switch language to Arabic.
  2. Go to inspect-element and switch to mobile-mode.
  3. Verify that you CANNOT zoom out.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • [] The file changes are relevant to the task objective.
  • [] Code is readable and includes appropriate commenting.
  • [] Code standards and best practices are followed.
  • [] QA/Test steps were successfully completed, if applicable.
  • [] Applicable logs are free of errors.

@SamiraMSadat
Copy link
Contributor

@WilliamYKwon Can you link the correct ticket to this PR? Thanks!

@WilliamYKwon
Copy link
Contributor Author

@WilliamYKwon Can you link the correct ticket to this PR? Thanks!

Oops sorry! I fixed it!

@SamiraMSadat SamiraMSadat merged commit f3b8cb5 into dev Jul 16, 2024
3 checks passed
@SamiraMSadat SamiraMSadat deleted the bug/VOTE-2368-zoom-issue-arabic-page branch July 16, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants