Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2411 Fix typo in overseas voter card #859

Merged
merged 1 commit into from
Jul 18, 2024
Merged

VOTE-2411 Fix typo in overseas voter card #859

merged 1 commit into from
Jul 18, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jul 17, 2024 •
edited by WilliamYKwon
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2411

Description

Fix the typo found in the overseas voter card

Deployment and testing

Post-deploy steps

  1. In the root folder of the repo, lando retune
  2. cd into web/themes/custom/votegov, npm run build

QA/Testing instructions

  1. Visit the homepage in English, and confirm the overseas voter card has the typo (space between "citizen and "from")
    image

  2. Select Spanish from the language dropdown, and confirm the overseas voter card translates
    image

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat merged commit ff6f8e2 into dev Jul 18, 2024
3 checks passed
@SamiraMSadat SamiraMSadat deleted the bug/VOTE-2411/typo-overseas-voter-card branch July 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamYKwon WilliamYKwon WilliamYKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamiraMSadat @WilliamYKwon