Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2433 Add Spanish translation for secondary nav aria label #873

Merged
merged 2 commits into from
Jul 23, 2024
Merged

VOTE-2433 Add Spanish translation for secondary nav aria label #873

merged 2 commits into from
Jul 23, 2024

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jul 23, 2024 •
edited by rkoch2
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2433

Description

Add a Spanish translation for the Secondary navigation aria-label

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Switch to Spanish on the homepage
  2. Run WAVE accessibility tools and/or NVDA
  3. Scroll down to the footer and confirm the aria label for the footer menu is in Spanish

image

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat requested a review from rkoch2 July 23, 2024 21:22
rkoch2
rkoch2 previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@rkoch2 rkoch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translated aria label shows up on my end! 👍

@SamiraMSadat SamiraMSadat requested a review from rkoch2 July 23, 2024 22:13
@SamiraMSadat SamiraMSadat merged commit cb83936 into dev Jul 23, 2024
3 checks passed
@SamiraMSadat SamiraMSadat deleted the bug/VOTE-2433/spanish-aria-nav branch July 23, 2024 22:15
tt-gsa added a commit that referenced this pull request Aug 1, 2024
@tt-gsa @rayestrada
@mlloydbixal @clmedders @smileytech @daniel-crowder @SamiraMSadat
Testing/vote 2227 update php version (#897)
dfed51c 
* VOTE-464 Initialize redesign votegov theme

* VOTE-464 resolve phplint errors with new theme

* VOTE-414: scaffolding for header

* Header refinements

* Update text formats for wysiwyg content

* Add ordered list to simple text format

* VOTE-499 configure main menu
VOTE-497 configure sitewide alert

* VOTE-415 Configure footer

* VOTE-528: state page title scaffolding

* revert block placement

* VOTE-525: add breadcrumb module

* VOTE-418: Homepage template scaffolding (#445)

* add nvrf block to state page nodes

* fix page title

* create registration type template suggestions

* satisfy phplint

* state page main content scaffolding

* votegov theme refinements

* Remove unused files from bixal_uswds theme

* Update CI/CD and references to new theme

* Move drupal_breadcrumb enable to right config dir

* testing rolling deploy on test

* Vote-2195: Cypress version and test updates (#860)

* Vote-2195: Update cypress to next version

* Vote-2195: Update to cypress tests

* Adding a sleep command to wait to rerun any failed test (#865)

* VOTE-2418: Resolve issue with taxonomy page loading when not loading from a parenting paragraph. (#857)

* VOTE-1121 Update SCSS to select USWDS packages (#837)

* VOTE-2240: Add high contrast main navigation menu styles (#822)

* VOTE-2319 Change date format for election day to long format (#863)

* Vote-2364:  Test coverage for accessibility toolbar (#862)

* remove zombie code

* add testing coverage for accessability tool bar

* VOTE-2429: Add external link class to Military and Overseas card (#866)

* VOTE-2388: adjust heading max width for heading (#869)

* VOTE-2424: removes lazy loading from hero image (#867)

* VOTE-2443 Replace spanish usa.gov links in the footer (#864)

* VOTE-2381: Add 'lang' attribute to language names (#868)

* VOTE-2477: Add translation for know your voter rights (#872)

* VOTE-2433 Add Spanish translation for secondary nav aria label (#873)

* VOTE-2485: Update robots.txt file for search.gov testing

* BUGFIX: remove 'of' from alias ignore settings (#861)

* VOTE-2272 replace touchpoints global button modal with a link to a hosted form (#870)

* VOTE-2444 start or update registration copy change (#878)

* VOTE-2444 Update registration heading in English

* VOTE-2444 Update Spanish translation

* VOTE-2324: Enable Somali for production. (#875)

* VOTE-2324: Enable Somali for production.

* VOTE-2324: Enable Somali translations for local environment.

* Vote 2425: hide untranslated content (#881)

* VOTE-2490 add config translations for home label (#882)

* VOTE-2505 Add (FVAP) back into temporary voter cards (#883)

* VOTE-972: Add robotstxt module. set robots.txt file per env (#758)

* VOTE-2372 Fix regression in state registration string

* VOTE-2324 Update somali config file

* HOTFIX replace Virginia with @state_name in string translations

* VOTE-2443 add missing double quotes around href attributes

* VOTE-2381 correct lang attributes in language swticher

* VOTE-2272 make touchpoints button translatable

* VOTE-2511: retry tome generating files or fail if the command exits non-zero (#886)

* VOTE-2241 configure a minimal maintenance page template (#884)

* Revert "VOTE-2444 start or update registration copy change (#878)"

This reverts commit ca6f179.

* VOTE-2512 Change link text on state page for English and Spanish

* VOTE-2510 Fix voter guide url axe test

* VOTE-970: update URIs as preparation for launch

* HOTFIX: disable FAQ JSON scheme on state pages

* testing buildpack version increase

---------

Co-authored-by: Ray Estrada <raymond.estrada@gsa.gov>
Co-authored-by: mlloydbixal <amanda.lloyd@gsa.gov>
Co-authored-by: Christian Medders - Bixal <88721460+clmedders@users.noreply.github.com>
Co-authored-by: Russell O'Neill <russell.oneill@gsa.gov>
Co-authored-by: Daniel Crowder <daniel.crowder@gsa.gov>
Co-authored-by: SamiraMSadat <108487505+SamiraMSadat@users.noreply.github.com>
Co-authored-by: Mandy Lloyd <121046395+mlloydbixal@users.noreply.github.com>
Co-authored-by: SamiraMSadat <samira.sadat@gsa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkoch2 rkoch2 rkoch2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamiraMSadat @rkoch2