Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2513 Disable translation on voter guide image field #895

Merged
merged 1 commit into from
Aug 2, 2024
Merged

VOTE-2513 Disable translation on voter guide image field #895

merged 1 commit into from
Aug 2, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Jul 31, 2024 •
edited
Loading

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2513

Description

Disable translation on voter guide image field

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/es/node/82/edit and confirm there is no image field in the edit form
  2. visit http://vote-gov.lndo.site/node/82/edit update the image and save
  3. visit http://vote-gov.lndo.site/guide-to-voting/college-student and confirm the new image displays
  4. visit http://vote-gov.lndo.site/es/guide-to-voting/college-student and confirm the new image displays

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada requested a review from mlloydbixal July 31, 2024 23:44
@mlloydbixal mlloydbixal merged commit ee7deb8 into dev Aug 2, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2513-guide-image branch August 14, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlloydbixal mlloydbixal mlloydbixal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayestrada @mlloydbixal