Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VOTE-2524: Update favicon size #898

Merged
merged 1 commit into from
Aug 2, 2024
Merged

VOTE-2524: Update favicon size #898

merged 1 commit into from
Aug 2, 2024

Conversation

rkoch2
Copy link
Contributor

@rkoch2 rkoch2 commented Aug 1, 2024

Jira ticket

VOTE-2524

Description

Update the favicon to be the correct (full) size.

Deployment and testing

Post-deploy steps

  1. lando retune

QA/Testing instructions

  1. Open vote-gov.lndo.site and check that the favicon appears in its full (larger) size. See below for comparison.
    Before:
    image

After:
image

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@SamiraMSadat SamiraMSadat merged commit 8fad157 into dev Aug 2, 2024
3 checks passed
@SamiraMSadat SamiraMSadat deleted the bug/VOTE-2524/resize-favicon branch August 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamiraMSadat SamiraMSadat SamiraMSadat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkoch2 @SamiraMSadat