Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2530-2531: add approvals to some post deploy steps in the pipeline #906

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

tt-gsa
Copy link
Contributor

@tt-gsa tt-gsa commented Aug 7, 2024

Jira ticket

VOTE-2530
VOTE-2531

Description

Add approvals to all post deploy upkeeps and an approval for the cypress job in stage.

Deployment and testing

QA/Testing instructions

  1. Observe pipeline.
  2. In dev, a manual approval should be required for the post deploy upkeep job.
  3. In stage, a manual approval should be required for the post deploy upkeep job and the cypress job that follows.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@tt-gsa tt-gsa requested a review from clmedders August 7, 2024 17:26
@clmedders clmedders merged commit 36a6232 into dev Aug 8, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2530-2531-pipeline-approvals branch August 8, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants