Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vote-1124: Add responsive image module to address lighthouse errors #920

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Vote-1124: Add responsive image module to address lighthouse errors #920

merged 1 commit into from
Aug 16, 2024

Conversation

clmedders
Copy link
Contributor

@clmedders clmedders commented Aug 9, 2024 •
edited
Loading

Jira ticket

Vote-1124

Description

Installed a module for responsive image to help address lighthouse errors

Deployment and testing

Post-deploy steps

  1. run lando retune

QA/Testing instructions

  1. load up local and open the console and run a mobile check light house. Should expect to not see the error properly size images

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@clmedders clmedders marked this pull request as ready for review August 9, 2024 19:54
@daniel-crowder daniel-crowder merged commit 84e4220 into dev Aug 16, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/vote-1124-responsive-image-module branch August 28, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-crowder daniel-crowder daniel-crowder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clmedders @daniel-crowder