Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2357 initialize a custom nvrf page route #934

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Aug 20, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2357

Description

Create a custom page for the nvrf app to live.

Deployment and testing

Post-deploy steps

  1. cd into the vote_nvrf module and run npm i and npm run build
  2. lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/register/washington/form and make sure the app loads with Washington in the content
  2. visit http://vote-gov.lndo.site/register/guam/form and make sure this results in a 404
  3. visit http://vote-gov.lndo.site/ko/register/washington/form and make sure this results in a 404

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada changed the base branch from dev to state-nvrf-integration August 20, 2024 01:15
@rayestrada rayestrada changed the title Feature/vote 2357 nvrf route VOTE-2357 initialize a custom nvrf page route Aug 20, 2024
@rayestrada rayestrada force-pushed the feature/VOTE-2357-nvrf-route branch from d24f6cb to 6663baf Compare August 20, 2024 18:51
@rayestrada rayestrada marked this pull request as ready for review August 20, 2024 19:13
@daniel-crowder daniel-crowder self-assigned this Aug 21, 2024
@rayestrada rayestrada merged commit d54aeab into state-nvrf-integration Aug 21, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2357-nvrf-route branch August 28, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants