Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/vote 2729 nvrf privacy path #938

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

rayestrada
Copy link
Contributor

@rayestrada rayestrada commented Aug 23, 2024

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-2729

Description

Adds data-privacyPath to the NvrfPageController and adds a rule between the header and the app on the app page

Deployment and testing

Post-deploy steps

  1. cd into votegov theme and run npm run build
  2. run lando retune

QA/Testing instructions

  1. visit http://vote-gov.lndo.site/register/alabama/form and confirm there is a line between the header and app
  2. click on the privacy policy link and make sure it is taking you to /form-filler-privacy-policy (this should be a 404 page because it does not exist. You can create a new basic page at that path and check it again if you would like)

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada changed the base branch from dev to state-nvrf-integration August 23, 2024 17:35
@rayestrada rayestrada marked this pull request as ready for review August 23, 2024 20:03
@clmedders clmedders merged commit b1f24f6 into state-nvrf-integration Aug 23, 2024
3 checks passed
@clmedders clmedders deleted the feature/VOTE-2729-nvrf-privacy-path branch August 23, 2024 20:15
rayestrada added a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants