Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-2741: split feature card styles from all card styles #950

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

mlloydbixal
Copy link
Contributor

@mlloydbixal mlloydbixal commented Aug 30, 2024

Jira ticket

VOTE-2741

Description

Splits the card styles that just apply to the feature cards from the rest of the styles that the nvrf also inherits from.

Deployment and testing

QA/Testing instructions

  1. lando retune
  2. visit landing page
  3. test feature cards on all screen sizes, confirm no changes
  4. visit http://vote-gov.lndo.site/register/washington/mail-in-form-filler
  5. navigate to the second page
  6. confirm the cards inherit the same styles *the mobile cards should stack and not change visually

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@mlloydbixal mlloydbixal requested a review from rayestrada August 30, 2024 20:20
@rayestrada rayestrada merged commit ca7b682 into dev Aug 30, 2024
3 checks passed
@rayestrada rayestrada deleted the feature/VOTE-2741/nvrf-cards branch September 25, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants