Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github actions CI. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added github actions CI. #4

wants to merge 1 commit into from

Conversation

newAM
Copy link
Contributor

@newAM newAM commented Sep 26, 2020

Would there be any interest in adding CI to this repository?

@Ravenslofty
Copy link
Member

Here's the question. How do you CI a USB stack? I'm all for testing and that kind of thing, but my gut instinct is that it would require physical hardware to check against, and that's going to be impossible on a CI virtual machine.

@dholroyd
Copy link
Collaborator

dholroyd commented Oct 9, 2020

You are right @Ravenslofty, running the code to assert that it works is going to be tough.

My feeling is that there's still some value in seeing if the code still builds etc in the face of future PRs -- I'd support adding some actions.

@newAM
Copy link
Contributor Author

newAM commented Oct 9, 2020

I have done embedded CI before it is entirely possible, just expensive. Probably not feasible here.

Compile checks are always free though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants