Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stroke classification & typology example demo #157

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

jGaboardi
Copy link
Collaborator

@jGaboardi jGaboardi commented Dec 21, 2024

Last week I mentioned about recreating the stroke classification & typology. It takes some minor updates to the code base to enable recording the information and some extra bits in for plotting. Here is the gist demoing 2 examples. I thing it's pretty cool, but not sure how actually useful it will be. Let me know yalls thoughts on if I should keep on the experimentation.

Of note – while the classifying of $\{\prime, *, \hat{}\}$ is performed in our current neatnet workflow, it is not (yet?) possible on this proposed functionality since it happens in differing locations & based on other artifacts.

@jGaboardi jGaboardi added documentation Improvements or additions to documentation algo/method labels Dec 21, 2024
@jGaboardi jGaboardi self-assigned this Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 70.27027% with 11 lines in your changes missing coverage. Please review.

Project coverage is 97.7%. Comparing base (c1c91ba) to head (853000c).

Files with missing lines Patch % Lines
neatnet/continuity.py 52.2% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #157     +/-   ##
=======================================
- Coverage   98.8%   97.7%   -1.1%     
=======================================
  Files          6       6             
  Lines        998    1021     +23     
=======================================
+ Hits         986     998     +12     
- Misses        12      23     +11     
Files with missing lines Coverage Δ
neatnet/simplify.py 98.3% <100.0%> (+<0.1%) ⬆️
neatnet/continuity.py 81.7% <52.2%> (-18.3%) ⬇️

@martinfleis
Copy link
Contributor

I suppose this can be useful in the paper and documentation when we explain how it all works but not sure it needs to be automatised. We can craft those figures by hand probably. But if this exists... why not use it.

I have looked at the gist only, not the code, fyi

@anastassiavybornova
Copy link
Collaborator

hey! sorry for being late on this. checked the code and the gist. looks really cool! i also agree with martin re usefulness for the paper and not-so-urgent full automatization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algo/method documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants