Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure for intent for VFX #96

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

paoloemilioselva
Copy link

These changes use the guideline as spec for a USD structure valid as baseline for a VFX intent.
The new folder provides scripts to create various steps as usd-layers for a VFX pipeline, as contributions to the final composed scene file.
The README describes the requirements for a VFX intent and how the structure fulfills those requirements.

Version has been removed from folder name.

A new script to generate edits via classes for the teapotScene has been provided.

README.md has been added to the intent-vfx folder with more details about the content of the folder.
Add anim-cycle for the asset and for the layout with time-offsets randomly distributed.
Reorganize the files in the repo
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thanks!

or

```
cd assets/simpleAsst
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: should be simpleAsset


This script will generate a layer providing a random distribution of specific anim-cycle with time-offsets, to control the amount of variations in the scene.

## Generate the scene step-by-step
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried doing this from scratch, but it didn't work since I still needed UtahTeapot.usd, perhaps highlighting the minimal needed to start the 'simpleAsset' or the minimal work it would take to add a custom asset to this flow could be helpful

layer = Sdf.Layer.CreateNew( i_filename, args={'format':'usda'} )
o_stage = Usd.Stage.Open( layer )
o_stage.SetStartTimeCode(1.0)
o_stage.SetEndTimeCode(1.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this endTimeCode be the same as startTimeCode? I manually changed this in teapotScene.usd to see the animation happening, since I couldn't otherwise see it

I see there are timeCodes in the camera script, but the scene still ends up being from 1 -> 1 for me

rgb_teapot_class = stage.CreateClassPrim("/_rgb_teapot")
rgb_teapot_material_over = stage.OverridePrim("/_rgb_teapot/mtl/default_material")
rgb_teapot_shader_over = stage.OverridePrim("/_rgb_teapot/mtl/default_material/default_shader_mtlx")
readprimvar_custom_color_output = add_readcolorprimvar_shader(stage,rgb_teapot_material_over,"custom_color")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but running the scene with the rgb_teapot overrides gives these warnings, probably pointing to why it's not working in usdview, but perhaps you'll understand why more quickly than me

        Error in 'pxrInternal_v0_25_2__pxrReserved__::HdSt_ApplyMaterialXFilter' at line 1455 in file /Users/andrewbeers/git/projects/OpenUSD/pxr/imaging/hdSt/materialXFilter.cpp : 'Unable to create the Glslfx Shader.
MxException: Could not find a nodedef for node 'Surface''

And

Warning: in _AddParameterInputsToTerminalNode at line 495 of /Users/andrewbeers/git/projects/OpenUSD/pxr/imaging/hdMtlx/hdMtlx.cpp -- NodeDef not found for Node 'standard_surface'
Warning: in HdMtlxCreateMtlxDocumentFromHdMaterialNetworkInterface at line 612 of /Users/andrewbeers/git/projects/OpenUSD/pxr/imaging/hdMtlx/hdMtlx.cpp -- Validation warnings for generated MaterialX file.
Node interface error: Input 'base_color' doesn't match declaration: <standard_surface name="Surface" type="surfaceshader">


```
cd assets/teapot
python ../../build_teapot.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it helpful to visualize these assets after the fact, possibly helpful to add:

usdview teapot.usd after the python script. this goes for the rest of the readme as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants