fix second field in generated PSM #384

abey-yoseph · 2022-06-01T15:39:46Z

PR Details

Description

Create a new variable to calculate the total milliseconds in the current minute.

Related Issue

#383

Motivation and Context

Secmark field in PSM needs to be corrected.

How Has This Been Tested?

Collected data at the West Intersection and verified the seconds field in the PSM is properly being updated via the docker log.

Types of changes

[x ] Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
[x ] I have read the CONTRIBUTING document.
V2XHUB Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.

paulbourelly999 · 2022-06-01T20:19:54Z

Your change looks fine. There are 3 code smells that may be nice to fix now. The one about using empty instead of size can replace the size check in your if statement and your for loop i think. The other one is about const cast. Is there a reason why you need to cast this as a const. Here are two examples of casting a string to a char* I found only. Would either work for you?

char* char_arr;
string str_obj("GeeksForGeeks");
char_arr = &str_obj[0]

// assigning value to string s
string st = "GeeksForGeeks";
//the c_str() function returns a const pointer
//to null terminated contents.
const char *str = st.c_str();