Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions workflows for Docker builds #257

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

SaikrishnaBairamoni
Copy link

PR Details

Description

Related GitHub Issue

Related Jira Key

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment on lines 6 to 8
- "develop"
- "master"
- "release/*"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what these lines do? Is it saying to build these branches, or ignore them? carma-develop, master, release branches we do want to build right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got my answer in private chat from Sai:
ci.yml: it will build and run units for sonar scanner analysis but does not push any images to docker hub dockerhub.yml: it will build and push of docker images when push occurs to develop, release branches, master but doesn't run any unit test or sonar scanner docker.yml: it will only build for feature branches and Pullrequest is opened, changed , merged (edited)

.github/workflows/docker.yml Outdated Show resolved Hide resolved

on:
push:
branches-ignore:
- "carma-develop"
- "develop"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be carma-develp?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to carma-develop


on:
push:
branches:
- "carma-develop"
- "develop"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be carma-develop?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to carma-develop

@SaikrishnaBairamoni SaikrishnaBairamoni merged commit 8a549ea into carma-develop Oct 24, 2023
2 checks passed
@SaikrishnaBairamoni SaikrishnaBairamoni deleted the fix/docker_build branch January 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants