Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update with driver status and alert #2

Merged
merged 17 commits into from
Feb 15, 2019
Merged

update with driver status and alert #2

merged 17 commits into from
Feb 15, 2019

Conversation

aswath1
Copy link

@aswath1 aswath1 commented Feb 5, 2019

No description provided.

@aswath1 aswath1 requested a review from qswawrq February 5, 2019 20:14
qswawrq
qswawrq suggested changes Feb 7, 2019
View reviewed changes
Copy link

@qswawrq qswawrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my inline comments. Two more things are needed: 1. Fix the issue when we unplug the camera. 2. Add unit tests to cover your changes.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
include/avt_vimba_camera/mono_camera.h Outdated Show resolved Hide resolved
src/mono_camera.cpp Outdated Show resolved Hide resolved
src/mono_camera.cpp Show resolved Hide resolved
src/mono_camera.cpp Outdated Show resolved Hide resolved
src/mono_camera.cpp Outdated Show resolved Hide resolved
src/nodes/mono_camera_node.cpp Outdated Show resolved Hide resolved
src/mono_camera.cpp Outdated Show resolved Hide resolved
qswawrq
qswawrq suggested changes Feb 11, 2019
View reviewed changes
include/avt_vimba_camera/mono_camera.h Outdated Show resolved Hide resolved
include/avt_vimba_camera/mono_camera.h Outdated Show resolved Hide resolved
include/avt_vimba_camera/mono_camera.h Outdated Show resolved Hide resolved
include/avt_vimba_camera/status_camera.h Outdated Show resolved Hide resolved
include/avt_vimba_camera/status_camera.h Outdated Show resolved Hide resolved
src/nodes/mono_camera_node.cpp Outdated Show resolved Hide resolved
src/status_camera.cpp Show resolved Hide resolved
src/status_camera.cpp Outdated Show resolved Hide resolved
src/status_camera.cpp Outdated Show resolved Hide resolved
src/status_camera.cpp Outdated Show resolved Hide resolved
qswawrq
qswawrq suggested changes Feb 12, 2019
View reviewed changes
include/avt_vimba_camera/mono_camera.h Outdated Show resolved Hide resolved
include/avt_vimba_camera/status_camera.h Show resolved Hide resolved
src/mono_camera.cpp Outdated Show resolved Hide resolved
src/mono_camera.cpp Outdated Show resolved Hide resolved
src/status_camera.cpp Show resolved Hide resolved
@qswawrq qswawrq changed the base branch from kinetic to develop February 12, 2019 16:05
@usdot-fhwa-stol usdot-fhwa-stol deleted a comment from qswawrq Feb 14, 2019
@qswawrq
Copy link

qswawrq commented Feb 15, 2019

This PR includes functional code and unit test. Merged.

@qswawrq qswawrq merged commit 0b8ada9 into develop Feb 15, 2019
@jtbaird jtbaird deleted the feature/pub_sub_dis_alert branch May 18, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qswawrq qswawrq qswawrq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswath1 @qswawrq