Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAR-2907: Feature/building with colcon #46

Merged
merged 7 commits into from
Sep 14, 2020

Conversation

jsun6065
Copy link

PR Details

Description

Changed docker build to allow it to be built with colcon instead of catkin_make.

Related Issue

usdot-fhwa-stol/carma-platform#810

Motivation and Context

Supports migration to ROS2.

How Has This Been Tested?

The package has been locally tested to build, the docker image has been locally tested to build, and the docker image is locally detected.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jsun6065 jsun6065 requested a review from msmcconnell August 21, 2020 15:17
@jsun6065 jsun6065 force-pushed the feature/building_with_colcon branch from 0e85b7b to 3717b80 Compare August 21, 2020 15:37
@jsun6065
Copy link
Author

There is a typo in the checkout script of this repo.

@msmcconnell msmcconnell requested review from aswath1 and removed request for msmcconnell September 14, 2020 14:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_121) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@msmcconnell msmcconnell merged commit 7febeab into develop Sep 14, 2020
@msmcconnell msmcconnell deleted the feature/building_with_colcon branch September 14, 2020 16:13
@msmcconnell msmcconnell changed the title Feature/building with colcon CAR-2907: Feature/building with colcon Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants