Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/launch ros2 dsrc driver #170

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Conversation

msmcconnell
Copy link
Contributor

PR Details

Description

This PR adds a drivers.launch.py file to carma config and uses it for the DSRC driver.

Related Issue

Supports usdot-fhwa-stol/carma-platform#1580

Motivation and Context

Working V2X stack in ROS2

How Has This Been Tested?

Successfully tested in blue lexus

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Michael McConnell and others added 2 commits February 14, 2022 21:39
@msmcconnell msmcconnell requested a review from JonSmet February 15, 2022 18:19
Copy link
Contributor

@JonSmet JonSmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Can they be carried over from the lexus config to the other config types as well?

@@ -0,0 +1,70 @@
# Copyright (C) 2021 LEIDOS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2022

JonSmet
JonSmet previously approved these changes Feb 15, 2022
@msmcconnell msmcconnell merged commit 7b2966d into develop Feb 15, 2022
@msmcconnell msmcconnell deleted the feature/launch_ros2_dsrc_driver branch February 15, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants