Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test fails in GuidanceStateMachine #368

Closed
1 of 3 tasks
qswawrq opened this issue Sep 25, 2019 · 1 comment
Closed
1 of 3 tasks

Unit test fails in GuidanceStateMachine #368

qswawrq opened this issue Sep 25, 2019 · 1 comment
Labels
anomaly Something isn't working

Comments

@qswawrq
Copy link
Contributor

qswawrq commented Sep 25, 2019

Types of Issue

  • Anomaly report (something appears to not work correctly)
  • Enhancement request (describe the enhancement being requested)
  • Other (please ensure the description clarifies why the issue doesn’t fall into either of the above categories)

Descriptive summary

Looks like the tests aren't getting run on CI, and thus code coverage metrics aren't available.

/opt/carma/src/CARMAPlatform/guidance/test/test_guidance_state_machine.cpp:22:42: error: ‘guidance_state_machine_factory’ was not declared in this scope
     guidance::GuidanceStateMachine gsm = guidance_state_machine_factory.createHardwareEngagedAutomationInstance();
                                          ^
/opt/carma/src/CARMAPlatform/guidance/test/test_guidance_state_machine.cpp:22:36: error: cannot declare variable ‘gsm’ to be of abstract type ‘guidance::GuidanceStateMachine’
     guidance::GuidanceStateMachine gsm = guidance_state_machine_factory.createHardwareEngagedAutomationInstance();
                                    ^
In file included from /opt/carma/src/CARMAPlatform/guidance/test/test_guidance_state_machine.cpp:17:0:
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:25:11: note:   because the following virtual functions are pure within ‘guidance::GuidanceStateMachine’:
     class GuidanceStateMachine
           ^
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:77:26: note: 	virtual void guidance::GuidanceStateMachine::StartUpState(guidance::GuidanceStateMachine::Signal)
             virtual void StartUpState(Signal signal) = 0;
                          ^
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:82:26: note: 	virtual void guidance::GuidanceStateMachine::DriversReadyState(guidance::GuidanceStateMachine::Signal)
             virtual void DriversReadyState(Signal signal) = 0;
                          ^
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:87:26: note: 	virtual void guidance::GuidanceStateMachine::ActiveState(guidance::GuidanceStateMachine::Signal)
             virtual void ActiveState(Signal signal) = 0;
                          ^
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:92:26: note: 	virtual void guidance::GuidanceStateMachine::EngagedState(guidance::GuidanceStateMachine::Signal)
             virtual void EngagedState(Signal signal) = 0;
                          ^
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:97:26: note: 	virtual void guidance::GuidanceStateMachine::InactiveState(guidance::GuidanceStateMachine::Signal)
             virtual void InactiveState(Signal signal) = 0;
                          ^
/opt/carma/src/CARMAPlatform/guidance/include/guidance/guidance_state_machine.hpp:102:26: note: 	virtual void guidance::GuidanceStateMachine::OffState(guidance::GuidanceStateMachine::Signal)
             virtual void OffState(Signal signal) = 0;
                          ^
/opt/carma/src/CARMAPlatform/guidance/test/test_guidance_state_machine.cpp: In member function ‘virtual void GuidanceStateMachineTest2_testStates_Test::TestBody()’:
/opt/carma/src/CARMAPlatform/guidance/test/test_guidance_state_machine.cpp:62:42: error: ‘guidance_state_machine_factory’ was not declared in this scope
     guidance::GuidanceStateMachine gsm = guidance_state_machine_factory.createSoftwareOnlyEngagedStateMachineInstance();
                                          ^
/opt/carma/src/CARMAPlatform/guidance/test/test_guidance_state_machine.cpp:62:36: error: cannot declare variable ‘gsm’ to be of abstract type ‘guidance::GuidanceStateMachine’
     guidance::GuidanceStateMachine gsm = guidance_state_machine_factory.createSoftwareOnlyEngagedStateMachineInstance();

Expected behavior

All unit tests should pass.

Actual behavior

One unit test fails.

Steps to reproduce the behavior

Check CI on current develop.

Related work

N/A

@qswawrq
Copy link
Contributor Author

qswawrq commented Oct 1, 2019

#371 fixes the issue.

@qswawrq qswawrq closed this as completed Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants