Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test build failure does not result in CI failure #369

Closed
1 of 3 tasks
msmcconnell opened this issue Sep 25, 2019 · 2 comments
Closed
1 of 3 tasks

Unit test build failure does not result in CI failure #369

msmcconnell opened this issue Sep 25, 2019 · 2 comments
Labels
anomaly Something isn't working Severity 4 Cosmetic problem or annoyance that doesn't materially affect system function

Comments

@msmcconnell
Copy link
Contributor

Types of Issue

  • Anomaly report (something appears to not work correctly)
  • Enhancement request (describe the enhancement being requested)
  • Other (please ensure the description clarifies why the issue doesn’t fall into either of the above categories)

Descriptive summary

As seen in issue #368, CI will not trigger a failure even if the unit tests fail to build. Instead it will report no code coverage metrics available. It is likely this is caused by the sonarcloud build wrapper hiding the error code from making it to the top of the shell. A similar thing appears to be happening with the regular code build except it will cause a CI failure because SonarCloud analysis will throw an error code at the end of the CI step.

Expected behavior

Unit test build failure results in CI failure

Actual behavior

Only regular build failures result in CI failure. Unit test build failures are reported as no code coverage metrics being available.

Steps to reproduce the behavior

PR with broken unit tests, but all other code builds.

@msmcconnell msmcconnell added the anomaly Something isn't working label Sep 25, 2019
@TonysCousin TonysCousin added the Severity 4 Cosmetic problem or annoyance that doesn't materially affect system function label May 5, 2020
@TonysCousin
Copy link
Member

Marking sev 4 because there is nothing functionally wrong with the production code, only how unit tests are being built.

@jtbaird
Copy link
Contributor

jtbaird commented May 7, 2020

Resolved via carma-base-3.7.1 and autoware.ai-3.8.2 releases, as well as above PRs.

@jtbaird jtbaird closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly Something isn't working Severity 4 Cosmetic problem or annoyance that doesn't materially affect system function
Projects
None yet
Development

No branches or pull requests

3 participants