Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for carma-base-3.7.1 release #40

Merged
merged 3 commits into from
May 7, 2020
Merged

updated for carma-base-3.7.1 release #40

merged 3 commits into from
May 7, 2020

Conversation

jtbaird
Copy link

@jtbaird jtbaird commented May 6, 2020

PR Details

Description

CI updates to allow circle to read errors from our CI scripts, and fixed link to Contributing.md in PULL_REQUEST_TEMPLATE.md

Related Issue

#369

Motivation and Context

CircleCI is has been running successfully in spite of test failures. This was due to errors in our code coverage scripts not being passed to the CircleCI shell. This issue has been addressed by carma-base-3.7.1 release, which this PR is designed to incorporate into this repo.

How Has This Been Tested?

Tested by breaking the test suite and confirming that Circle fails as expected.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    CARMA Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jtbaird jtbaird requested a review from MishkaMN May 6, 2020 21:38
MishkaMN
MishkaMN previously approved these changes May 6, 2020
@sonarcloud
Copy link

sonarcloud bot commented May 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jtbaird jtbaird merged commit 7530c9c into develop May 7, 2020
@jtbaird jtbaird deleted the feature/ci_update branch May 7, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants