Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR adds rviz2 configuration port of existing carma_default.rviz.
It also removed unused and outdated topics.
No other installation is needed, since rviz2 is shipped and installed with ros-foxy-desktop and is in carma-base already.
Result:
NOTE1: Currently all vehicles and simulation PCs are still in ros-noetic on the host machines. So this configuration can only be used inside docker container (which I confirmed acceptable with @JonSmet). Therefore, typical usage will look like:
If the platform_ros2 container is running on a specific ip (e.g. simulation PCs) ,
/usr/bin/carma
should be edited to match the ip (e.g.--network=host
to--network=192.168.88.25
) and then above cmd will work.NOTE2: When loading point cloud map on ROS1 rviz (even when started inside the docker container as such above), the fps stays stable at 31fps. However, on rviz2, it comes down to 18-24 fps when static and zoomed in around the vehicle. And down to 6fps when the vehicle is moving (down to 6fps if zoomed out while static and the whole map is rendered on the view). Simulation PCs still work great at 31fps with PCL map loaded due to its fast processor/GPU.
I investigated this a bit more, and tried applying this potential fix that is implemented for a related bug by building rviz2 from source, but it didn't help. I didn't put too much effort in making it more stable since
Related GitHub Issue
NA
Related Jira Key
https://usdot-carma.atlassian.net/browse/CAR-6061
Motivation and Context
ROS2 migration from ROS1.
How Has This Been Tested?
Sim PC and White Fusion
Types of changes
Checklist: