Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rviz2 configuration port #2425

Merged
merged 2 commits into from
Aug 15, 2024
Merged

rviz2 configuration port #2425

merged 2 commits into from
Aug 15, 2024

Conversation

MishkaMN
Copy link
Contributor

@MishkaMN MishkaMN commented Aug 13, 2024

PR Details

Description

This PR adds rviz2 configuration port of existing carma_default.rviz.
It also removed unused and outdated topics.
No other installation is needed, since rviz2 is shipped and installed with ros-foxy-desktop and is in carma-base already.
Result:
image

NOTE1: Currently all vehicles and simulation PCs are still in ros-noetic on the host machines. So this configuration can only be used inside docker container (which I confirmed acceptable with @JonSmet). Therefore, typical usage will look like:

carma exec "source /opt/carma/install_ros2/setup.bash && rviz2 -d /opt/carma/install_ros2/carma/share/carma/rviz/carma_default_ros2.rviz"

If the platform_ros2 container is running on a specific ip (e.g. simulation PCs) , /usr/bin/carma should be edited to match the ip (e.g. --network=host to --network=192.168.88.25) and then above cmd will work.

NOTE2: When loading point cloud map on ROS1 rviz (even when started inside the docker container as such above), the fps stays stable at 31fps. However, on rviz2, it comes down to 18-24 fps when static and zoomed in around the vehicle. And down to 6fps when the vehicle is moving (down to 6fps if zoomed out while static and the whole map is rendered on the view). Simulation PCs still work great at 31fps with PCL map loaded due to its fast processor/GPU.

I investigated this a bit more, and tried applying this potential fix that is implemented for a related bug by building rviz2 from source, but it didn't help. I didn't put too much effort in making it more stable since

  1. we will upgrade to humble anyways and
  2. we have workaround of using ROS1 rviz if needed, and
  3. 6-8fps is not great, but still doable. We can actually just turn off PCD and Lidar while carma is running which bumps the fps to 15+. This is because those are only needed during initialization at the moment.

Related GitHub Issue

NA

Related Jira Key

https://usdot-carma.atlassian.net/browse/CAR-6061

Motivation and Context

ROS2 migration from ROS1.

How Has This Been Tested?

Sim PC and White Fusion

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@MishkaMN MishkaMN added the enhancement New feature or request label Aug 13, 2024
@MishkaMN MishkaMN requested a review from adev4a August 13, 2024 18:25
@MishkaMN MishkaMN self-assigned this Aug 13, 2024
Copy link

@MishkaMN
Copy link
Contributor Author

Created this issue:
#2427

@MishkaMN MishkaMN requested a review from adev4a August 14, 2024 14:00
@MishkaMN MishkaMN merged commit db4df43 into develop Aug 15, 2024
4 checks passed
@adev4a adev4a deleted the car-6061-rviz2 branch August 16, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants