Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS1 Cleanup #163

Merged
merged 1 commit into from
Sep 19, 2024
Merged

ROS1 Cleanup #163

merged 1 commit into from
Sep 19, 2024

Conversation

john-chrosniak
Copy link
Contributor

@john-chrosniak john-chrosniak commented Sep 16, 2024 •
edited
Loading

PR Details

Description

This PR renames the j2735_msgs and j3224_msgs packages after these packages were merged into j2735_v2x_msgs and j3224_v2x_msgs in carma-msgs PR #243.

Related GitHub Issue

NA

Related Jira Key

ARC-205

Motivation and Context

Old package names are outdated and no longer exist.

How Has This Been Tested?

Untested - Marked as draft

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@john-chrosniak john-chrosniak self-assigned this Sep 16, 2024
@john-chrosniak john-chrosniak marked this pull request as draft September 16, 2024 17:48
@john-chrosniak john-chrosniak marked this pull request as ready for review September 19, 2024 15:33
@john-chrosniak john-chrosniak changed the title changed to new j2735 package ROS1 Cleanup Sep 19, 2024
@MishkaMN MishkaMN self-requested a review September 19, 2024 20:09
@john-chrosniak john-chrosniak merged commit c2a2469 into develop Sep 19, 2024
1 of 2 checks passed
@john-chrosniak john-chrosniak deleted the arc-205-ros1-cleanup branch September 19, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MishkaMN MishkaMN MishkaMN approved these changes

Assignees

@john-chrosniak john-chrosniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-chrosniak @MishkaMN