Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/k900 for 4.4.0 release #107

Merged
merged 7 commits into from
May 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
# Pull docker image from docker hub
# XTERM used for better catkin_make output
docker:
- image: usdotfhwastol/autoware.ai:carma-system-4.3.0
- image: usdotfhwastol/autoware.ai:carma-system-4.4.0
user: carma
environment:
TERM: xterm # use xterm to get full display output from build
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# License for the specific language governing permissions and limitations under
# the License.

FROM usdotfhwastol/autoware.ai:carma-system-4.3.0 as setup
FROM usdotfhwastol/autoware.ai:carma-system-4.4.0 as setup

ARG ROS1_PACKAGES=""
ENV ROS1_PACKAGES=${ROS1_PACKAGES}
Expand All @@ -24,7 +24,7 @@ COPY --chown=carma . /home/carma/src/
RUN ~/src/docker/checkout.bash
RUN ~/src/docker/install.sh

FROM usdotfhwastol/autoware.ai:carma-system-4.3.0
FROM usdotfhwastol/autoware.ai:carma-system-4.4.0


ARG BUILD_DATE="NULL"
Expand Down
33 changes: 27 additions & 6 deletions docker/build-image.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,43 +23,64 @@ echo ""
echo "##### $IMAGE Docker Image Build Script #####"
echo ""

ROS1_PACKAGES=""
ROS2_PACKAGES=""
ROS1_PACKAGES_COLLECT=false
ROS2_PACKAGES_COLLECT=false

while [[ $# -gt 0 ]]; do
arg="$1"
case $arg in
-v|--version)
ROS1_PACKAGES_COLLECT=false
ROS2_PACKAGES_COLLECT=false

COMPONENT_VERSION_STRING="$2"
shift
shift
;;
--system-release)
ROS1_PACKAGES_COLLECT=false
ROS2_PACKAGES_COLLECT=false

SYSTEM_RELEASE=true
shift
;;
-p|--push)
ROS1_PACKAGES_COLLECT=false
ROS2_PACKAGES_COLLECT=false

PUSH=true
shift
;;
-d|--develop)
ROS1_PACKAGES_COLLECT=false
ROS2_PACKAGES_COLLECT=false

USERNAME=usdotfhwastoldev
COMPONENT_VERSION_STRING=develop
shift
;;
--ros-1-packages|--ros1)
ROS1_PACKAGES=""
ROS1_PACKAGES_COLLECT=true
ROS2_PACKAGES_COLLECT=false

shift
;;
--ros-2-packages|--ros2)
ROS2_PACKAGES=""
ROS1_PACKAGES_COLLECT=false
ROS2_PACKAGES_COLLECT=true

shift
;;
*)
# Var test based on Stack Overflow question: https://stackoverflow.com/questions/5406858/difference-between-unset-and-empty-variables-in-bash
# Asker: green69
# Answerer: geekosaur
if [ "${ROS2_PACKAGES+set}" = "set" ]; then
ROS2_PACKAGES="$ROS2_PACKAGES $arg"
elif [ "${ROS1_PACKAGES+set}" = "set" ]; then
if $ROS1_PACKAGES_COLLECT; then
ROS1_PACKAGES="$ROS1_PACKAGES $arg"
elif $ROS2_PACKAGES_COLLECT; then
ROS2_PACKAGES="$ROS2_PACKAGES $arg"
else
echo "Unknown argument $arg..."
exit -1
Expand All @@ -70,7 +91,7 @@ while [[ $# -gt 0 ]]; do
done

if [[ ! -z "$ROS1_PACKAGES$ROS2_PACKAGES" ]]; then
echo "Performing incremental build of image to rebuild packages: $ROS1_PACKAGES $ROS2_PACKAGES..."
echo "Performing incremental build of image to rebuild packages: ROS1>> $ROS1_PACKAGES ROS2>> $ROS2_PACKAGES..."

echo "Updating Dockerfile references to use most recent image as base image"
# Trim of docker image LS command sourced from
Expand Down
4 changes: 2 additions & 2 deletions docker/checkout.bash
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ if [[ "$BRANCH" = "develop" ]]; then
git clone https://github.com/usdot-fhwa-stol/carma-msgs.git ${dir}/src/CARMAMsgs --branch $BRANCH
git clone https://github.com/usdot-fhwa-stol/carma-utils.git ${dir}/src/CARMAUtils --branch $BRANCH
else
git clone https://github.com/usdot-fhwa-stol/carma-msgs.git ${dir}/src/CARMAMsgs --branch carma-system-4.3.0
git clone https://github.com/usdot-fhwa-stol/carma-utils.git ${dir}/src/CARMAUtils --branch carma-system-4.3.0
git clone https://github.com/usdot-fhwa-stol/carma-msgs.git ${dir}/src/CARMAMsgs --branch carma-system-4.4.0
git clone https://github.com/usdot-fhwa-stol/carma-utils.git ${dir}/src/CARMAUtils --branch carma-system-4.4.0
fi
44 changes: 0 additions & 44 deletions docs/pull_request_template.md

This file was deleted.