Dockerfile Optimization #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of some output to 7 decimal places.
Optimize Dockerfiles for Smaller and Faster Deployments
DockerHub Image Documentation
Update do_kafka_test to set DOCKER_HOST_IP
Update KAFKA_CONTAINER_NAME to resolve dynamically
…ot-changes Sync CDOT develop branch with latest USDOT changes
Release Notes for v1.3.0
dan-du-car
reviewed
Jan 31, 2024
Dockerfile-nsv
Outdated
| WORKDIR /cvdi-stream | ||
|
|
||
| # add runtime dependencies | ||
| RUN apk add --upgrade --no-cache \ |
There was a problem hiding this comment.
Is it possible to COPY the libs from build image? The same comments for other Dockerfiles that install the same dependencies from build stage image.
There was a problem hiding this comment.
The dockerfiles have now been modified to include 3 image stages:
- runtime-deps: Image with runtime dependencies
- builder: Inherit from runtime-deps and build
- final: Inherit from runtime-deps and copy built files
This removes the need to install the runtime dependencies twice.
dan-du-car
reviewed
Jan 31, 2024
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v2 |
There was a problem hiding this comment.
Remove the docker setup action
There was a problem hiding this comment.
This has been removed.
dan-du-car
reviewed
Jan 31, 2024
| - name: Build | ||
| uses: docker/build-push-action@v3 |
There was a problem hiding this comment.
remove docker build/push action
There was a problem hiding this comment.
This has been removed.
Removed docker CI actions & reduced installation duplication in dockerfiles
|
This PR is ready for re-review. |
dan-du-car
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some changes have been made to the Dockerfiles with the aim to enhance performance and efficiency:
Additionally, some output from a cv-lib method has been decreased in precision to fix a failing unit test in alpine.
Testing
The changes have been thoroughly tested with the following results:
These updates are expected to contribute to a more efficient and streamlined development and deployment process.