Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Updates & Removal of TIM Support #41

Merged
merged 46 commits into from
Sep 24, 2024

Conversation

dmccoystephenson
Copy link
Contributor

README Update: Supported Message Types

Problem

The README mentions basic safety messages (BSMs) but lacks a clear list of supported message types. This can lead users to mistakenly attempt processing unsupported message types.

Solution

A new 'Supported Message Types' section has been added to the README, clarifying that only BSMs are currently supported.

Removal of TIM Support

Problem

Although the PPM currently supports processing TIMs, this isn't part of the data flow to RSUs and the SDX. TIMs are only filtered based on geofences and do not contain personally identifiable information. Therefore, TIM support is unnecessary.

Solution

All references to TIMs have been removed from the project.

Testing

  • The do_kafka_test.sh script has been verified to work with these changes.
  • The unit tests pass.
  • The program spins up correctly.

Documentation Update

Problem

The documentation was outdated.

Solution

The documentation has been reviewed & revised for accuracy.

dmccoystephenson and others added 30 commits June 20, 2024 11:03
Added 'Supported Message Types' section to README
@dmccoystephenson dmccoystephenson marked this pull request as ready for review September 9, 2024 16:25
@@ -103,7 +115,7 @@ Example configuration files can be found in the [jpo-cvdp/config](../config) dir

The details of the settings and how they affect the function of the PPM follow:

## Sanitization Flag
### Sanitization Flag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to remove the TIM related doc here?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed!

1. Pull the project into VSCode
1. Reopen the project in a dev container
1. Open the terminal.
1. Type "sudo su" to run commands as root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
It seems the permission needs some work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev container configuration has been modified to make all shell scripts executable upon starting.

docs/testing.md Outdated Show resolved Hide resolved
docs/testing.md Outdated Show resolved Hide resolved
…m-docker-compose-files

Removed unnecessary 'version' element from docker-compose files
…iguration

Added standalone configuration instructions to testing documentation
…e-in-dev-container

Modified dev container to make all scripts executable upon creation
…nfiguration-doc

Removed TIM reference from configuration documentation
@dmccoystephenson dmccoystephenson marked this pull request as ready for review September 23, 2024 20:53
@dan-du-car dan-du-car merged commit b6feb5f into usdot-jpo-ode:develop Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants