Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ProcessedMap and Schema Versions #76

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Update ProcessedMap and Schema Versions #76

merged 4 commits into from
Dec 10, 2024
+372 −356

Conversation

drewjj
Copy link
Collaborator

@drewjj drewjj commented Nov 18, 2024 •
edited
Loading

Updates the schema for the jpo-geojsonconverter repository.

  • ProcessedMap has been adjusted to not require fields required by the CI guidelines if J2735 allows for them to be optional
  • ProcessedMap has been adjusted to support the WKT output
  • All schemas have been updated to use the JSON schema draft version 2020-12 in an effort to allow GCP to utilize these same schemas since GCP does not support 2019
  • Minor formatting changes for some of the schemas made by Liquid Studio

@drewjj drewjj requested a review from iyourshaw November 18, 2024 16:58
iyourshaw
iyourshaw approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@iyourshaw iyourshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Verified that the unit tests pass. Just one comment that the Position3D data structure could be referenced instead of copied.

jpo-geojsonconverter/src/main/resources/schemas/processed-map.schema.json Outdated Show resolved Hide resolved
jpo-geojsonconverter/src/main/resources/schemas/processed-map.schema.json Outdated Show resolved Hide resolved
@drewjj drewjj merged commit 0daa80f into develop Dec 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iyourshaw iyourshaw iyourshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewjj @iyourshaw