Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/relationship #322

Merged
merged 37 commits into from
Aug 11, 2022
Merged

Refactor/relationship #322

merged 37 commits into from
Aug 11, 2022

Conversation

sknick-iastate
Copy link
Collaborator

This pull request addresses the relationship refactoring in Issue #197.

Below is a summary of the major changes for the refactoring:

  • Deprecate existing relationship object
  • Add new related_road_events object which has attributes specific for the use cases within WZDx
  • Added RelatedRoadEventTypes that address various use cases within WZDx including: road event sequence, related detours/work zones, recurring work zones, and moving operations.
  • Updated examples to show use of new related_road_events object

A summary of the new object and enumerations include:

related_road_events property on the RoadEvent object (replaces relationship)

Property Name Value Description Conformance Notes
related_road_events Array; RelatedRoadEvents A list describing one or more road events which are related to this road event, such as a work zone project it is part of or another road event that occurs before or after it in sequence. Optional

RelatedRoadEvents Object

The RelatedRoadEvents object is used to identify another road event that is related to a road event.

Property Name Value Description Conformance Notes
type RelatedRoadEventType The type of road event being identifed, such as another sequence of related work zones, a detour, or next road event in sequence. Required
id String An identifier for the related road event by the type property. Required

Used By

Property Object
related_road_events RoadEventCoreDetails

RelatedRoadEventType Enumerated Type

Describes a type of related road event, such as a work zone project, recurrent work zone, or detour-type road event.

Value Description
first-in-sequence The first road event in a sequence of road events that together describe a full work zone or detour
next-in-sequence The next (subsequent) road event in a sequence of road events that together describe a full work zone or detour
first-occurrence The first road event of the first occurrence of a recurrent work zone. End users will need to iterate using the first road event to find all relevant road events to a related work zone
next-occurrence The first road event of the next occurrence of a recurrent work zone. End users will need to iterate using the first road event to find all relevant road events to a related work zone
related-work-zone First road event of related work zones (i.e. not part of a sequence of road events or recurrent work zone) that are relevant to the given road event. End users will need to iterate using the first road event to find all relevant road events to a related work zone
related-detour First road event of related detours (i.e. not part of a sequence of road events) that are relevant to the given road event. End users will need to iterate using the first road event to find all relevant road events to a related detour
planned-moving-operation First road event of a related planned moving operation work zones (i.e. not part of a sequence of road events) that are relevant to the given road event. End users will need to iterate using the first road event to find all relevant road events to a related work zone
active-moving-operation First road event of a related active moving operation work zones (i.e. not part of a sequence of road events) that are relevant to the given road event. End users will need to iterate using the first road event to find all relevant road events to a related work zone

Used By

Property Object
type RelatedRoadEvents

spec-content/objects/RelatedRoadEvents.md Outdated Show resolved Hide resolved
spec-content/objects/RelatedRoadEvents.md Outdated Show resolved Hide resolved
spec-content/objects/RelatedRoadEvents.md Outdated Show resolved Hide resolved
spec-content/objects/RoadEventCoreDetails.md Outdated Show resolved Hide resolved
spec-content/objects/RoadEventCoreDetails.md Outdated Show resolved Hide resolved
spec-content/enumerated-types/RelatedRoadEventType.md Outdated Show resolved Hide resolved
spec-content/enumerated-types/RelatedRoadEventType.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@j-d-b j-d-b added this to the v4.1 milestone Jun 3, 2022
@j-d-b j-d-b added Refactor This item related to refactoring the specification. New Functionality This item relates to adding new functionality to the specification labels Jun 3, 2022
@j-d-b
Copy link
Collaborator

j-d-b commented Jun 3, 2022

/spec-content/README.md needs to be updated with the new object and enumerated type.

Copy link
Collaborator

@mark-mockett mark-mockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple additional comments, but once Jacob's comments are addressed I think this will be ready to go

examples/README.md Outdated Show resolved Hide resolved
spec-content/objects/RoadEventCoreDetails.md Outdated Show resolved Hide resolved
spec-content/objects/RelatedRoadEvents.md Outdated Show resolved Hide resolved
spec-content/README.md Outdated Show resolved Hide resolved
@sknick-iastate sknick-iastate mentioned this pull request Jun 9, 2022
examples/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Functionality This item relates to adding new functionality to the specification Refactor This item related to refactoring the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the Relationship object: explicitly define and identify entities related to a road event
4 participants