-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/relationship #322
Merged
mark-mockett
merged 37 commits into
usdot-jpo-ode:release/v4.1
from
sknick-iastate:refactor/relationship
Aug 11, 2022
Merged
Refactor/relationship #322
mark-mockett
merged 37 commits into
usdot-jpo-ode:release/v4.1
from
sknick-iastate:refactor/relationship
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also removed relationship that has been deprecated
also removed deprecated relationship
also removed deprecated relationship
also removed deprecated relationships
also removed deprecated relationship
j-d-b
requested changes
Jun 3, 2022
examples/WZDxFeed/scenario3_shoulder_bidirectional_linestring_example.geojson
Outdated
Show resolved
Hide resolved
j-d-b
added
Refactor
This item related to refactoring the specification.
New Functionality
This item relates to adding new functionality to the specification
labels
Jun 3, 2022
/spec-content/README.md needs to be updated with the new object and enumerated type. |
Also added additional details about deprecated relationship
mark-mockett
reviewed
Jun 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple additional comments, but once Jacob's comments are addressed I think this will be ready to go
j-d-b
reviewed
Jun 6, 2022
j-d-b
reviewed
Jun 7, 2022
Closed
j-d-b
reviewed
Jul 11, 2022
j-d-b
approved these changes
Jul 14, 2022
jlarsonOmahaNE
approved these changes
Jul 14, 2022
j-d-b
reviewed
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Functionality
This item relates to adding new functionality to the specification
Refactor
This item related to refactoring the specification.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the relationship refactoring in Issue #197.
Below is a summary of the major changes for the refactoring:
related_road_events
object which has attributes specific for the use cases within WZDxrelated_road_events
objectA summary of the new object and enumerations include:
related_road_events
property on the RoadEvent object (replacesrelationship
)related_road_events
RelatedRoadEvents Object
The RelatedRoadEvents object is used to identify another road event that is related to a road event.
type
id
type
property.Used By
related_road_events
RelatedRoadEventType Enumerated Type
Describes a type of related road event, such as a work zone project, recurrent work zone, or detour-type road event.
first-in-sequence
next-in-sequence
first-occurrence
next-occurrence
related-work-zone
related-detour
planned-moving-operation
active-moving-operation
Used By
type