Skip to content

Commit

Permalink
cleanup from reviewing my own code (#1848)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattbowen-usds committed Aug 31, 2022
1 parent ef5635b commit 2bd86f6
Showing 1 changed file with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# flake8: noqa: W0613,W0611,F811
from dataclasses import dataclass
from typing import Optional
from data_pipeline.etl.score.etl_utils import floor_series
import pandas as pd
import numpy as np
import pytest
Expand All @@ -17,17 +16,6 @@

pytestmark = pytest.mark.smoketest

"""Tiles and data pipeline: The goal here is to smoke test correctness
We should check for wrong variable ported over to the tiles by making sure the column name for each thing we want in usa.csv has the same value as
the column name for the tiles csv. This is NOT the same as checking that the column has been renamed. Rather, this requires looking at the
methodology of the tool, seeing what should be represented, and ensuring that variable is indeed represented.
-- I think we actually have to do a lot of this by hand and in QA
Check for USVI and Guam in tiles
We should check that even census tracts that have NULLs for every indicator get included in the tiles and in the csv and are never dropped
-- For this, I think we need to check on the front end? It looks like Tippecanoe will drop all nulls
"""


@pytest.fixture
def tiles_df(scope="session"):
Expand Down Expand Up @@ -65,9 +53,6 @@ def tiles_df(scope="session"):
"UF_PFS",
"WF_PFS",
"UST_PFS",
# "IALMILHSE_PFS",
# "IAPLHSE_PFS",
# "IAULHSE_PFS",
]


Expand Down

0 comments on commit 2bd86f6

Please sign in to comment.