Skip to content

Commit

Permalink
Mark tests as smoketests (#1848)
Browse files Browse the repository at this point in the history
  • Loading branch information
mattbowen-usds committed Aug 26, 2022
1 parent 192ebe6 commit 542ecaf
Showing 1 changed file with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import pandas as pd
import pytest
from data_pipeline.utils import get_module_logger
from data_pipeline.config import settings
from data_pipeline.etl.score.constants import (
TILES_SCORE_COLUMNS,
THRESHOLD_COUNT_TO_SHOW_FIELD_NAME,
USER_INTERFACE_EXPERIENCE_FIELD_NAME,
)

logger = get_module_logger(__name__)
pytestmark = pytest.mark.smoketest

"""Tiles and data pipeline: The goal here is to smoke test correctness
Expand All @@ -23,7 +22,7 @@


@pytest.fixture
def tiles_df():
def tiles_df(scope='session'):
return pd.read_csv(
settings.APP_ROOT / "data" / "score" / "csv" / "tiles" / "usa.csv",
dtype={"GTF": str},
Expand Down Expand Up @@ -103,10 +102,6 @@ def test_column_presence(tiles_df):
), f"tiles/usa.csv is missing columns from TILE_SCORE_COLUMNS: {missing_columns}"


def test_colunmn_types_as_expected(tiles_df):
breakpoint()
assert False

# For each data point that we visualize, we want to confirm that
# (1) the column is represented in tiles_columns
# (2) the column values are of the TYPE they are supposed to be

0 comments on commit 542ecaf

Please sign in to comment.