Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update create-score-version github action to upload files to S3 for beta version only #2181

Open
vim-usds opened this issue Mar 2, 2023 · 0 comments · May be fixed by #2194
Open

update create-score-version github action to upload files to S3 for beta version only #2181

vim-usds opened this issue Mar 2, 2023 · 0 comments · May be fixed by #2194
Assignees
@travis-newby
Labels
data-pipeline devops

Comments

@vim-usds
Copy link
Contributor

vim-usds commented Mar 2, 2023 •
edited
Loading

Describe the bug

  1. In the create-score-version github action, line 85, is currently copying contents from the files directory to downloadable folder on S3. This is happening on all builds. This should only happen when the target version is beta.
  2. There are some curl commands that check the existence of downloadable files, which may not be needed any more.

To Reproduce
Steps to reproduce the behavior:

  1. When create-score-version is run, it will write the contents of files to the S3 downloadable folder

Expected behavior
The expected behavior is for this to only occur when the target version is beta.

Ideally, we may want to create a specific folder for the beta files. This would allow for other versions in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@travis-newby travis-newby

Labels
data-pipeline devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update create-score-version Github Action usds/justice40-tool
2 participants
@travis-newby @vim-usds