-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update create-score-version Github Action #2194
base: main
Are you sure you want to change the base?
Update create-score-version Github Action #2194
Conversation
Organize create-score-version around logical steps, add ability to test more easily, and update files to be in their own folder unique to the version being deployed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this started and improving the flow! Wrote up a few ideas on ways to potentially improve. Let's discuss :)
…tic files for the sake of the build, and update score version (and constants) to use that directory
** Score Deployed! **
|
Score Comparison SummaryHi! I'm the Score Comparator. I compared the score in production (version 1.0) to the locally calculated score. Here are the results. ColumnsI compared the columns. Here's what I found.
ScoresI compared the scores, too. Here's what I found.
|
** Map Deployed! ** |
@travis-newby - I don't believe the cache invalidation is in the script. We could place it in another ticket if you think that's better. Just set this up here. As an FYI, the BE distribution ID is E1324VDMNCO97N. All other env vars would be the same as above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also a fast follow will be to update the FE links once these files are on S3 :) |
This PR updates the create-score-version Github Action to,
test
input option to upload everything to a new test folder and run smoke tests from there. That way we can test this script without deploying version 1.0 again.data_pipeline/files
) to be in their own folder, and name that folderdata_pipeline/files/static
to indicate that these files don't change (often). Files in this folder will get automatically uploaded during the build process.