Adding Simple URL-based feature flags #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that sees new features, so that we can control the message and positioning of our tool Implements simple feature flagging via URL parameters. Provide "?flags=x,y,z" to enable flags x, y, and z.
NatHillardUSDS
requested review from
esfoobar-usds,
switzersc-usds and
TomNUSDS
as code owners
TomNUSDS
previously approved these changes
Jun 9, 2021
TomNUSDS
reviewed
Jun 9, 2021
| @@ -68,8 +68,8 @@ | |||
| &::before { | |||
| color: white; | |||
| background-color: #00a91c; | |||
| content: '✓' | |||
| content: "✓"; | |||
There was a problem hiding this comment.
Think this is an indication that prettier isn't running correctly for my ide setup?
There was a problem hiding this comment.
Ah yeah, that appears to have snuck in - this was formatted automatically when I ran gatsby develop
…gured a prefix-path for use with github pages, but this didn't match the path within the s3 bucket. Upload content to a subfolder and ensure pusers access site from /justice40-tool/ (#115)
TomNUSDS
approved these changes
Jun 9, 2021
lscharen
added a commit
to lscharen/justice40-tool
that referenced
this pull request
Jan 30, 2024
vim-usds
added a commit
that referenced
this pull request
Feb 7, 2024
vim-usds
added a commit
that referenced
this pull request
Feb 8, 2024
* Update survey links; ref external repo PR #117 * Restore the removed contact page survey link * Fix testing snapshots * linter errors * Update Spanish data survey link --------- Co-authored-by: Lucas Scharenbroich <lscharen@prowestgis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66: As a developer, I want to limit the audience that sees new features, so that we can control the message and positioning of our tool.
Implements simple feature flagging via URL parameters. Provide "?flags=x,y,z" to enable flags x, y, and z.
Also adds simple flagging for the "Timeline" feature: http://localhost:8000/?flags=timeline now shows the timeline.