Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend release branch to main #1829

Merged
merged 137 commits into from
Nov 21, 2022
Merged

Frontend release branch to main #1829

merged 137 commits into from
Nov 21, 2022

Conversation

vim-usds
Copy link
Contributor

@vim-usds vim-usds commented Aug 17, 2022 •
edited
Loading

Purpose

This PR will contain all FE changes for the 1.0 launch

Features

Indicators status

  • Future flood risk
  • Future wildfire risk
  • lack of green space
  • lack of plumbing
  • transportation barriers
  • leaky underground tanks
  • demographics
  • historic underinvestment (redlining)?
  • abandoned land mines
  • FUDS

Demographics

  • Add demographics UI to sidepanel
  • Connect real BE data

Geolocation

  • works on desktop
  • works on mobile
  • Fix UI on desktop and mobile

Tribal layer selection

  • overlay in base map
  • remove all toggle logic and UI
  • connect BE signals for TA_COUNT and TA_PERC

Side panel UI

  • remove all up and down
  • missing data should have a Value of missing data should be '--' with no Icon
  • when data is missing, the SubText should say "missing data". Reduce size to fit in one line.
  • instead of highlighting the entire indicator(with a baby blue background), only highlight the Value (dark blue background around the value) when the indicator is above the threshold. change the text color of the value to white.
  • instead of a blue dot on the category, change the entire background (to dark blue) of the category when it is above the associated threshold(s), otherwise leave as is. change the text color and the icon color (the plus sign) to white.
  • test on mobile (iOS and Android)
  • test on desktop (Chrome, Safari and Firefox)
  • review all ind titles and desc from content 1.0 doc
  • category title, indicator name, desc, value, subtext should all be grey-warm-90
  • Title and Value should have the same font treatment (weight and size as spacer)
  • remove initial spacer (at least one)
  • AND space remove bg color and ensure that vertical spacing b/w indicator is the same including spacers (check each category to make sure it applies equally)
  • all subtext in one line
  • on the value that has a background color, tighten up, equal spacing on all sides (2px left and right, 1px top and bottom)
  • Methodology version (pt, pb = 1rem)
  • update Methodology version to 1.0
  • update non-selected copy
  • updated 1.0 designs

Copy

  • update 404 page
  • all copy updates from Content 1.0 doc on Explore the map page
  • copy bugs from bug party

About page

  • Most of About page copy (some missing links that are TBD)
  • Navigation links for MethPage and AboutPage (desktop)
  • Navigation links for MethPage and AboutPage (mobile)

Bugs

  • removes duplicate higher ed
  • all links should be the same color
  • Logo title shouldn't wrap

vim-usds added 30 commits July 25, 2022 16:20
@vim-usds
Add Geolocation from behind feature flag
e1f4df8
@vim-usds
Comment updates from PR feedback
125a66a
@vim-usds
Modify geolocate icon and beacon to be black
8d2f3d2
@vim-usds
Upgrade lb dependencies
49df74a 
- upgrade uswds to 2.13.3
- upgrade trussworks to 3.1.0
- fix breaking changes on Accordion, Search, SummaryBox, Collections,
@vim-usds
Fixes links that were off center
6b37e5d
@vim-usds
Modify styling for geolocation
ccc1ca1
@vim-usds
Modify geolocation message
afc399c
@vim-usds
Add mobile and desktop geolocating
2282620
@vim-usds
Modify disabled label tooltip message
32814a7
@vim-usds
Add indicators to Puerto Rico (to release branch) (#1688)
3c7c23e 
* Add indicators to Puerto Rico

* Remove linguistic iso in Puerto Rico only
@vim-usds
Adds demographics v1
4a2bc42 
- This uses the built-in accordion component
@vim-usds
Add custom Accordion component to match designs
f7d2e27
@vim-usds
Update AreaDetail snapshots
c53b2c1
@vim-usds
Adding some better comments
96f6536
@vim-usds
Add USWDS expand to demographics side panel
504181d
@vim-usds
Remove justice40-tool from prefix-path
b699598
@vim-usds
Update staging link to new CDN link
73f5024
@vim-usds
Remove messaging on mobile
9f2fe1a
@vim-usds
Prettify test file
3a31f2b
@vim-usds
Add TractInfo component
d0ff171
@vim-usds
Style TractDemo component
432bb65
@vim-usds
Move Methodology version to bottom of sidepanel
0dbc550
@vim-usds
Add custom expand / collapse component
7817d41 
- adds a11y
- adds chevron from USWDS icons
@vim-usds
Align Geolocate icon and Search
40e7b80 
- align geolocate and search according to mock for desktop and mobile
@vim-usds
Add tribal toggle (UI only)
70b9072
@vim-usds
Refactor Sources/Layers to allow for tribal switching
d4aed78 
- Remove census tracts layers into it's own component
- Create a tribal layer component
- Update LayerSelector component tests
- update OS map to react to layer selector
-
@vim-usds
Add tribal info to side panel and feature selection
1d3af30 
- create a state variable to keep track of weather or not the layer was toggled
- allow mapInfoPanel to reset on layer switch
- allow AreaDetail to show census and tribal info
- allow LayerSelector to set layer toggled
- Add selectedFeature to both MapTribal and MapTract components
- create various tribal constants for styling
- i18n constants
@vim-usds
Update snapshots
c3d1c3a
@vim-usds
Update tribal path on production build
ffffe53
@vim-usds
Comment update
7ad8b83
@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/b37aace49a14dc5d7665daf71f6555c3197d75e2/client/src/intl/en.json

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-5fd46f/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/5fd46fe21317887fe464411d99c8aca80f01b588/client/src/intl/en.json

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-2b75eb/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/2b75ebaf4337c918b330aa9f7ac8bfa2cee3c0e2/client/src/intl/en.json

@vim-usds
Update copy based on Katherine's findings
5a2ed76 
- update snapshots
- remaining changes from Content 1.0
@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-041bfb/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/041bfbb17cf36953a5f0964557c68d801e98c33a/client/src/intl/en.json

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-6d715e/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/6d715ed8140bad74480420027a006c309db9f9ba/client/src/intl/en.json

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-4b6e67/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/4b6e67f4ad8dcd0ae378d45e303895755eea4762/client/src/intl/en.json

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-109ece/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/109ece8a739ad5747edeaf636772773fa568912e/client/src/intl/en.json

mattbowen-usds
mattbowen-usds approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@mattbowen-usds mattbowen-usds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, there's no way I can review all of this, but we need to go live and main has protection, so 👍

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-37e87b/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/37e87b77150c116c4079f4550d4c9f5416124be5/client/src/intl/en.json

@github-actions
Copy link

🚢 Here is the frontend staging link: 🚢
Find it here: https://screeningtool-staging.geoplatform.gov/1829-9d64af/en/ !

@github-actions
Copy link

** 👋 Attention translators!! 👋 **
Copy changes have resulted in a new en.json file. Please download en.json file and send to translators: https://github.com/usds/justice40-tool/blob/9d64af5d51ab462a7bd6b089e6b92e3e1099974f/client/src/intl/en.json

@vim-usds vim-usds merged commit 669d1d3 into main Nov 21, 2022
@vim-usds vim-usds deleted the vimusds/release/frontend-narwhal-2 branch November 21, 2022 23:20
@github-actions
Copy link

🚢 PR Deployed! 🚢
Find it here: https://screeningtool.geoplatform.gov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattbowen-usds mattbowen-usds mattbowen-usds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vim-usds @emma-nechamkin @mattbowen-usds @esfoobar-usds @lucasmbrown-usds