Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertions around codebook #2014

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Add assertions around codebook #2014

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
571e9a6
Add assertion around codebook (#1505)
mattbowen-usds Oct 13, 2022
c549aa9
Assert csv and excel have same cols (#1505)
mattbowen-usds Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions data/data-pipeline/data_pipeline/etl/score/etl_score_post.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,22 @@ def _load_downloadable_zip(self, downloadable_info_path: Path) -> None:
"fields"
],
)
assert codebook_df["csv_label"].equals(codebook_df["excel_label"]), (
"CSV and Excel differ. If that's intentional, "
"remove this assertion. Otherwise, fix it."
)
# Check the codebook to make sure it matches the download files
assert not set(codebook_df["csv_label"].dropna()).difference(
downloadable_df.columns
), "Codebook is missing columns from downloadable files"
assert (
len(
downloadable_df.columns.difference(
set(codebook_df["csv_label"])
)
)
== 0
), "Codebook has columns the downloadable files do not"

# load codebook to disk
codebook_df.to_csv(codebook_path, index=False)
Expand Down