Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove survey link from the contact page. Fixes Issue #2245. #2246

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Remove survey link from the contact page. Fixes Issue #2245. #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d986f89
Remove survey link from the contact page. Fixes Issue #2245.
lscharen Sep 22, 2023
03acc10
Add back whitespace to pass snapshot testing
lscharen Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions client/src/components/HowYouCanHelp/tests/__snapshots__/howYouCanHelp.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,7 @@ exports[`rendering of the HowYouCanHelp checks if various text fields are visibl
.
</li>
<li>
Any other questions? The best way to contact the Council on Environmental Quality (CEQ) is by filling out this
<a
class="usa-link usa-link--external"
data-cy=""
href="https://www.surveymonkey.com/r/5LZ7MNB"
rel="noreferrer"
target="_blank"
>
form
</a>
. Otherwise, email:
Any other questions? Email:
<a
class="usa-link"
href="/en/methodology"
Expand Down
2 changes: 1 addition & 1 deletion client/src/data/copy/about.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export const HOW_YOU_CAN_HELP_LIST_ITEMS = {
/>,
LIST_ITEM_4: <FormattedMessage
id={'about.page.how.you.can.help.list.item.4'}
defaultMessage={`Any other questions? The best way to contact the Council on Environmental Quality (CEQ) is by filling out this <link2>form</link2> . Otherwise, email: <link1>Screeningtool-Support@omb.eop.gov</link1>.`}
defaultMessage={`Any other questions? Email: <link1>Screeningtool-Support@omb.eop.gov</link1>.`}
description={`Navigate to the about page. You will see How you can help list item 3`}
values={{
link1: linkFn(PAGES_ENDPOINTS.METHODOLOGY, true, false),
Expand Down
22 changes: 11 additions & 11 deletions client/src/data/copy/contact.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,17 @@ export const CENSUS_TRACT_FEEDBACK = {
// `}
// description={'Navigate to the contact page, this is the census tract feedback section'}
// />,
PARAGRAPH3: <FormattedMessage
id={'contact.page.census.tract.feedback.para3'}
defaultMessage={`
The best way to contact the Council on Environmental Quality (CEQ) is by filling out <link1>this form</link1>.
`}
description={'Navigate to the survey. Spanish should substitute <link2> to get Spanish link! Already coded to support'}
values={{
link1: COMMON_COPY.linkFn('https://www.surveymonkey.com/r/5LZ7MNB', false, true),
link1es: COMMON_COPY.linkFn('https://www.surveymonkey.com/r/CGTH5P7', false, true),
}}
/>,
// PARAGRAPH3: <FormattedMessage
// id={'contact.page.census.tract.feedback.para3'}
// defaultMessage={`
// The best way to contact the Council on Environmental Quality (CEQ) is by filling out <link1>this form</link1>.
// `}
// description={'Navigate to the survey. Spanish should substitute <link2> to get Spanish link! Already coded to support'}
// values={{
// link1: COMMON_COPY.linkFn('https://www.surveymonkey.com/r/5LZ7MNB', false, true),
// link1es: COMMON_COPY.linkFn('https://www.surveymonkey.com/r/CGTH5P7', false, true),
// }}
// />,
};


8 changes: 2 additions & 6 deletions client/src/intl/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"description": "Navigate to the about page. You will see How you can help list item 3"
},
"about.page.how.you.can.help.list.item.4": {
"defaultMessage": "Any other questions? The best way to contact the Council on Environmental Quality (CEQ) is by filling out this <link2>form</link2> . Otherwise, email: <link1>Screeningtool-Support@omb.eop.gov</link1>.",
"defaultMessage": "Any other questions? Email: <link1>Screeningtool-Support@omb.eop.gov</link1>.",
"description": "Navigate to the about page. You will see How you can help list item 3"
},
"about.page.how.you.can.help.para.1": {
Expand Down Expand Up @@ -259,16 +259,12 @@
"defaultMessage": "https://static-data-screeningtool.geoplatform.gov/data-pipeline/data/score/downloadable/cejst_technical_support_document.pdf",
"description": "Navigate to the Alerts on any page. This will be the link to the techinical support document."
},
"contact.page.census.tract.feedback.para3": {
"defaultMessage": "The best way to contact the Council on Environmental Quality (CEQ) is by filling out <link1>this form</link1>.",
"description": "Navigate to the survey. Spanish should substitute <link2> to get Spanish link! Already coded to support"
},
"contact.page.fab.survey.text": {
"defaultMessage": "Help improve the tool",
"description": "Navigate to the contact page, this is the text for floating action button"
},
"contact.page.general": {
"defaultMessage": "Otherwise, email CEQ at: {general_email_address}.",
"defaultMessage": "Email CEQ at: {general_email_address}.",
"description": "Contact page body text"
},
"contact.page.header.text": {
Expand Down
2 changes: 1 addition & 1 deletion client/src/intl/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"contact.page.census.tract.feedback.para3": "La mejor forma de ponerse en contacto con el Consejo sobre la Calidad del Medio Ambiente (CEQ, por sus siglas en ingles) es al completar este <link1es>formulario</link1es>.",
"contact.page.fab.survey.link": "https://www.surveymonkey.com/r/P3LWTSB",
"contact.page.fab.survey.text": "Ayude a mejorar la herramienta",
"contact.page.general": "De lo contrario, envíe un correo electrónico al CEQ a: {general_email_address}.",
"contact.page.general": "Envíe un correo electrónico al CEQ a: {general_email_address}.",
"contact.page.header.text": "Contacto",
"contact.page.request.for.info.box.body": "El periodo de Solicitud de información en el Registro Federal para el periodo de la versión beta abierto al público se cerró el {rfiExpDate}.",
"contact.page.request.for.info.box.title": "Solicitud de información",
Expand Down
2 changes: 1 addition & 1 deletion client/src/intl/es_3.17.23-translated-final.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@
"description": "Navegue a la página Contacto, este es el texto para el botón circular flotante."
},
"contact.page.general": {
"defaultMessage": "De lo contrario, envíe un correo electrónico al CEQ a: {general_email_address}.",
"defaultMessage": "Envíe un correo electrónico al CEQ a: {general_email_address}.",
"description": "Texto del cuerpo de la página Contacto."
},
"contact.page.header.text": {
Expand Down
3 changes: 1 addition & 2 deletions client/src/pages/contact.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,11 @@ const ContactPage = ({location}: IContactPageProps) => {
<h2>
{intl.formatMessage(CONTACT_COPY.PAGE_INTRO.PAGE_SUB_HEADING)}
</h2>
<p>{CONTACT_COPY.CENSUS_TRACT_FEEDBACK.PARAGRAPH3}</p>
<p>
<FormattedMessage
id={'contact.page.general'}
description={'Contact page body text'}
defaultMessage={`Otherwise, email CEQ at: {general_email_address}.`}
defaultMessage={`Email CEQ at: {general_email_address}.`}
values={{
general_email_address:
<LinkTypeWrapper
Expand Down
12 changes: 1 addition & 11 deletions client/src/pages/tests/__snapshots__/about.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,17 +869,7 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
.
</li>
<li>
Any other questions? The best way to contact the Council on Environmental Quality (CEQ) is by filling out this
<a
class="usa-link usa-link--external"
data-cy=""
href="https://www.surveymonkey.com/r/5LZ7MNB"
rel="noreferrer"
target="_blank"
>
form
</a>
. Otherwise, email:
Any other questions? Email:
<a
class="usa-link"
href="/en/methodology"
Expand Down
17 changes: 1 addition & 16 deletions client/src/pages/tests/__snapshots__/contact.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,22 +432,7 @@ exports[`rendering of the DatasetContainer checks if various text fields are vis
Contact us
</h2>
<p>

The best way to contact the Council on Environmental Quality (CEQ) is by filling out
<a
class="usa-link usa-link--external"
data-cy=""
href="https://www.surveymonkey.com/r/5LZ7MNB"
rel="noreferrer"
target="_blank"
>
this form
</a>
.

</p>
<p>
Otherwise, email CEQ at:
Email CEQ at:
<a
class="usa-link usa-link--external"
data-cy=""
Expand Down
Loading