Add CI check for all individual crates #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
requested review from
a team,
cmichi,
HCastano and
SkymanOne
as code owners
HCastano
reviewed
Mar 15, 2023
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Check each crate |
There was a problem hiding this comment.
@ascjones do you mind making a small follow-up explaining why we need this check?
For someone just reading the CI file they wouldn't have enough context to know why we manually check all crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CI only runs workspace level
buildandtestcommands. However it is possible that these will succeed but when building an individual crate it will fail. e.g the CI for #1010 succeeded, but when it came to releasing it, it didn't work because of missing features.My guess is that there is another crate which depends on
primitive-typesat the workspace level, which pulls in the required features via feature unification.This PR iterates over the crates in the
cratesdir and runscheckon each one. When performing a release on an individual crate,cargo publishwill runcargo checkbefore publishing, so we want to catch any errors which would arise there in the CI.