Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport ink_metadata in transcoder crate #1522

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

0xLucca
Copy link
Contributor

@0xLucca 0xLucca commented Mar 4, 2024

Summary

Closes #1521

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Description

This PR solves issue #1521

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Mar 4, 2024

User @0xLucca, please sign the CLA here.

CHANGELOG.md Outdated Show resolved Hide resolved
@cmichi
Copy link
Collaborator

cmichi commented Mar 6, 2024

@0xLucca Can you fix the CI? It should be a simple cargo fmt.

image

0xLucca and others added 2 commits March 6, 2024 14:37
Co-authored-by: Michael Müller <mich@elmueller.net>
@0xLucca 0xLucca requested review from ascjones and cmichi March 6, 2024 17:41
@ascjones
Copy link
Collaborator

ascjones commented Mar 6, 2024

Please provide a more descriptive title to the PR

@0xLucca 0xLucca changed the title Solve issue #1521 Reexport ink_metadata in transcoder crate Mar 6, 2024
@0xLucca
Copy link
Contributor Author

0xLucca commented Mar 6, 2024

I've just updated the PR title

@cmichi cmichi merged commit a96e8b2 into use-ink:master Mar 7, 2024
10 checks passed
This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InkProject not exported from ink_metadata
3 participants