-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump subxt
and subxt-signer
versions
#1722
Conversation
76ae46d
to
643bb61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
//! internal storage structure, we parse the file and overwrite those paths relative to | ||
//! the host machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seams incorrect format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI was failing because of this issue. You can run it locally with:
cargo +nightly clippy --message-format=json --profile debug-ci --all-features --all-targets -- -D warnings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contract-build
seems to be depending on a yanked version of zip
crate.
See: https://crates.io/crates/zip/versions
Maybe we could bump it here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we just need a small change to the changelog. See below.
Maybe we should add some information to the README that c-c is compatible starting from version 14. Previously, we supported very old versions—I tested it starting from version 8. |
This PR upgrades the
subxt
andsubxt-signer
library from version 0.35.3 to 0.37.0.This upgrade is necessary because version 0.37 of
subxt
includes support for the signed extensionCheckMetadataHash
.This solves an issue when uploading a smart contract on certain chains.
How to Replicate the Issue:
This will throw the error:
This issue is resolved with this upgrade.
Note
In addition to bumping the
subxt
version, some other changes were made:metadata_v11.scale
and its test. The test was failing here. Based on what I read in an issue opened in the subxt repo link, it seems the only way to fix it is to regenerated the metadata files used in the tests after the upgrade.However, using the latest
subxt-cli
to regenerate the file for V11 was showing an error:The reason for this error is that
subxt
doesn't support anything before V14. Sincecargo-contract
relies heavily onsubxt
, the best approach seems to be supporting only from V14 onwards.