Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extrinsic call types, upload, and events public #1873

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

peterwht
Copy link
Contributor

@peterwht peterwht commented Dec 16, 2024

Summary

Closes #_

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependent on the specific version of ink or pallet-contracts? (uses pallet-contracts)

Description

These types provide useful code for managing Subxt interactions with pallet-contracts. Exposing them allows reuse in other crates, while still allowing the crates to have flexibility and manage the submission of the transaction.

Checklist before requesting a review

  • I have added an entry to CHANGELOG.md

chore: make events public

chore: make types pub for use in other crates
@peterwht peterwht force-pushed the peter/chore-make-types-pub branch from 7c8fc48 to 2f8213a Compare December 16, 2024 16:02
@peterwht peterwht changed the title Make some types pub for use in other crates Make extrinsic call types, upload, and events public Dec 16, 2024
@cmichi cmichi merged commit 62dfbcf into v5.x.x Dec 16, 2024
10 of 12 checks passed
@cmichi cmichi deleted the peter/chore-make-types-pub branch December 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants