Reflect changes in chain-extensions API #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
reviewed
Jan 31, 2023
versioned_docs/version-4.0.0-alpha.1/macros-attributes/chain-extension.md
Outdated
Show resolved
Hide resolved
cmichi
reviewed
Jan 31, 2023
| @@ -95,7 +89,7 @@ pub trait MyChainExtension { | |||
|
|
|||
| Default value: `true` | |||
|
|
|||
| By default all chain extension methods return a `Result<T, E>` where `E: From<Self::ErrorCode>`. | |||
| By default all chain extension methods should return a `Result<T, E>` where `E: From<Self::ErrorCode>`. | |||
There was a problem hiding this comment.
Can you clarify what the implication is if they don't?
There was a problem hiding this comment.
Can you clarify what the implication is if they don't?
I think lines 106-107 states the implication
cmichi
reviewed
Jan 31, 2023
versioned_docs/version-4.0.0-alpha.1/macros-attributes/chain-extension.md
Outdated
Show resolved
Hide resolved
cmichi
reviewed
Jan 31, 2023
versioned_docs/version-4.0.0-alpha.1/macros-attributes/chain-extension.md
Outdated
Show resolved
Hide resolved
…xtension.md Co-authored-by: Michael Müller <mich@elmueller.net>
…xtension.md Co-authored-by: Michael Müller <mich@elmueller.net>
…xtension.md Co-authored-by: Michael Müller <mich@elmueller.net>
cmichi
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update chain-extensions page to reflect breaking changes introduced by use-ink/ink#1569