Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use-inkathon dns frontend example #56

Merged
merged 9 commits into from
Feb 23, 2024
Merged

Conversation

peetzweg
Copy link
Contributor

@peetzweg peetzweg commented Jan 5, 2024

This PR is part is meant to be compared with #55 .

Adds frontend example with just the hooks library of inkathon called useinkathon, which is a similar library to the useink library used in the other examples.

This example demonstrate a very minimal dapp setup. Not deployment scripts or component libraries used here.

Personally I would enjoy an example like this more than #55 as especially for beginners the inkathon template can be very overwhelming and not yield a quick success if not experienced with the tools chosen by the inkathon template.

https://github.com/paritytech/ink-examples/blob/344f0b1bbcff27a7c8ed2e2f95a6cc61644f8d3a/dns/frontend/package.json#L12-L17

useinkathon-small.mov

@cmichi
Copy link
Collaborator

cmichi commented Jan 18, 2024

Thank you for creating both PR's to illustrate the different approaches.

I agree with you in that this PR is way simpler and easier to maintain. Let's go with this approach.

Can you close the other one and make this one ready for review?

@peetzweg peetzweg changed the title feat: implements dns example with useinkathon hooks library only feat: use-inkathon dns frontend example Jan 23, 2024
@peetzweg peetzweg marked this pull request as ready for review January 23, 2024 15:41
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the videos you put in the PR's. Could you try adding this one to the Readme as well?

@peetzweg
Copy link
Contributor Author

@cmichi great idea, added the video as a gif to the readme of the example. 👍
https://github.com/paritytech/ink-examples/tree/pz/dns-frontent-example/dns/frontend

@peetzweg peetzweg merged commit 53213d8 into main Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants