Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated rustfmt configuration options #1309

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

ascjones
Copy link
Collaborator

@ascjones ascjones commented Jul 5, 2022

Removes report_todo, report_fixme and license_template_path.

Should we consider with replacing these options with alterantives? Certainly we could just do a simple grep for detecting todo and fixme.

@paritytech-cicd-pr
Copy link

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the examples/* contracts from this branch with cargo-contract 1.4.0-25bfb96 and comparing them to ink! master:

Δ Optimized Size Δ Used Gas Total Optimized Size Total Used Gas
accumulator 1.00 K
adder 2.04 K
contract-introspection 2.32 K
contract-terminate 0.92 K 275_000
contract-transfer 8.31 K 75_000
data-structures 1.73 K
delegate-calls 2.89 K 76_242
delegator 6.34 K 232_136
dns 8.81 K 225_000
erc1155 16.74 K 450_000
erc20 8.42 K 225_000
erc721 11.62 K 600_000
flipper 1.24 K 75_000
forward-calls 2.87 K 151_411
incrementer 1.14 K
mother 12.16 K
multisig 25.28 K 470_240
rand-extension 3.79 K 75_000
seal-code-hash 1.39 K
seal-ecdsa 1.71 K
set-code-hash 1.49 K 150_000
subber 2.06 K
trait-erc20 8.69 K 225_000
trait-flipper 0.97 K 75_000
trait-incrementer 1.12 K 150_000
updated-incrementer 9.72 K
upgradeable-flipper 1.48 K

Link to the run | Last update: Tue Jul 5 18:32:52 CEST 2022

@codecov-commenter
Copy link

Codecov Report

Merging #1309 (43be0c9) into master (97f41b5) will increase coverage by 25.20%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #1309       +/-   ##
===========================================
+ Coverage   47.12%   72.33%   +25.20%     
===========================================
  Files         176      176               
  Lines        5920     5920               
===========================================
+ Hits         2790     4282     +1492     
+ Misses       3130     1638     -1492     
Impacted Files Coverage Δ
crates/storage/src/traits/impls/prims.rs 95.16% <0.00%> (+1.61%) ⬆️
crates/lang/ir/src/ir/attrs.rs 82.27% <0.00%> (+3.60%) ⬆️
crates/lang/ir/src/ir/trait_def/item/mod.rs 90.16% <0.00%> (+4.91%) ⬆️
crates/lang/ir/src/ir/item_impl/constructor.rs 93.84% <0.00%> (+6.15%) ⬆️
crates/env/src/engine/off_chain/test_api.rs 86.84% <0.00%> (+7.89%) ⬆️
crates/lang/ir/src/ir/idents_lint.rs 71.42% <0.00%> (+9.52%) ⬆️
crates/storage/src/traits/impls/mod.rs 77.77% <0.00%> (+11.11%) ⬆️
crates/env/src/engine/off_chain/impls.rs 44.70% <0.00%> (+12.35%) ⬆️
crates/env/src/api.rs 33.80% <0.00%> (+12.67%) ⬆️
crates/engine/src/test_api.rs 85.71% <0.00%> (+13.18%) ⬆️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f41b5...43be0c9. Read the comment docs.

@ascjones ascjones merged commit 391b47b into master Jul 6, 2022
@ascjones ascjones deleted the aj/remove-deprecated-rustfmt-options branch July 6, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants