Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: Add issue numbers + make E2E dependencies optional #1424

Merged
merged 3 commits into from
Sep 28, 2022
Merged

E2E: Add issue numbers + make E2E dependencies optional #1424

merged 3 commits into from
Sep 28, 2022

Conversation

cmichi
Copy link
Collaborator

@cmichi cmichi commented Sep 28, 2022

Follow-up to #1395.

@cmichi cmichi changed the title E2E: Issue numbers + optional deps E2E: Add issue numbers + make E2E dependencies optional Sep 28, 2022
ascjones
ascjones approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏. The next improvement would be to make the contract metadata std build not build these dependencies. Haven't tested it yet but I assume this would take considerably longer now on the first build.

@cmichi cmichi merged commit 802bb13 into master Sep 28, 2022
@cmichi cmichi deleted the cmichi-add-issue-numbers branch September 28, 2022 17:25
@cmichi cmichi mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascjones ascjones ascjones approved these changes

@HCastano HCastano Awaiting requested review from HCastano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmichi @ascjones