-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract e2e testing framework to its own crate #1429
Conversation
Thanks a lot for this! I don't see how it will resolve #1428, but we should merge it nonetheless, as it's more structured this way. I don't think it will resolve our issue because of the following:
I think what we have to do is require every contract to have a
The we can have the
|
The idea is that
|
Waiting for use-ink/cargo-contract#763 to be merged and released, then update |
@@ -183,18 +183,16 @@ pub mod give_me { | |||
#[cfg(test)] | |||
mod e2e_tests { | |||
use super::*; | |||
use ink::env::e2e::*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously required to bring the reexported tokio
crate into scope for the tokio::test
macro. In order to make this properly hygienic, I have replaced the usage of the tokio::test
macro with explicit async execution (copied from tokio::test
) 7e63d1c
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
==========================================
+ Coverage 70.84% 70.89% +0.05%
==========================================
Files 193 193
Lines 6077 6071 -6
==========================================
- Hits 4305 4304 -1
+ Misses 1772 1767 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Andrew!
Pulls all of the e2e testing framework and the macro into their own crates.
Should resolve #1428