Backport #1379 #1401 #1418 into v3.x.x and fix tests
#1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sending payments with contract msg calls (#1379) * first ver.: transfer_in api function implememted but we can't have it in on-chain env * transfer_in moved to test_api * doc + example updated * Update examples/contract-transfer/lib.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * use stmt moved to macro * docs and nitty gritties * moved the macro to the test mod * spell fix * next review round suggestions applied * Use four spaces for macro indentation Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Hernando Castano <hernando@hcastano.com>
agryaznov
requested review from
a team,
cmichi,
ascjones and
HCastano
as code owners
ascjones
approved these changes
Oct 18, 2022
agryaznov
force-pushed
the
ag-v3.x.x
branch
5 times, most recently
from
c5a81ad
to
23d61d4
Compare
agryaznov
changed the title
v3.x.x and fix testsv3.x.x and fix tests
|
CI passes (except ink-waterfall) for the following toolchain: Making it all green for the latest Rust would require additional efforts (worth devoting a separate PR if needed). ink_waterfall (currently fails), meanwhile, was already broken on the previous release (though for a different reason) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following three PRs to backport:
ink_env::pay_with_call!helper macro for off-chain emulation of sending payments with contract msg calls (Addink_env::pay_with_call!helper macro for off-chain emulation of sending payments with contract msg calls #1379)pay_with_callto take multiple arguments (Allowpay_with_callto take multiple arguments #1401)matchto a separate constants (Moved constants frommatchto a separate constants #1418)+ tests fixed