Apply clippy suggestions #1552
Merged
Apply clippy suggestions #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkymanOne
requested review from
cmichi,
ascjones and
HCastano
as code owners
HCastano
reviewed
Dec 16, 2022
.gitlab-ci.yml
Outdated
| @@ -28,7 +28,7 @@ variables: | |||
| CARGO_TARGET_DIR: "/ci-cache/${CI_PROJECT_NAME}/targets/${CI_COMMIT_REF_NAME}/${CI_JOB_NAME}" | |||
| # CI_IMAGE is changed to "-:staging" when the CI image gets rebuilt | |||
| # read more https://github.com/paritytech/scripts/pull/244 | |||
| CI_IMAGE: "paritytech/ink-ci-linux:production" | |||
| CI_IMAGE: "paritytech/ink-ci-linux:staging" | |||
There was a problem hiding this comment.
If the CI passes with this we can revert it and merge
There was a problem hiding this comment.
Okay so the CI didn't pass, and I suspect it has to do with #1547.
I'm gonna say we merge this anyways since we'll need this fix to build the production image
This reverts commit f9b767b.
HCastano
approved these changes
Dec 16, 2022
HCastano
added a commit
that referenced
this pull request
Jan 23, 2023
* Apply clippy suggestions * fmt * apply clippy suggestions * Check build using `stating` image * Revert "Check build using `stating` image" This reverts commit f9b767b. Co-authored-by: Hernando Castano <hernando@hcastano.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1548