Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC20 E2E tests for LangError changes #1553

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

HCastano
Copy link
Contributor

The original PR for the ERC20 E2E tests had been sitting around a bit
long and didn't account for the extra Result. I should've merged
master into the PR before merging, haha.

The original PR for the ERC20 E2E tests had been sitting around a bit
long and didn't account for the extra `Result`. I should've merged
`master` into the PR before merging, haha.
Copy link
Contributor

@SkymanOne SkymanOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1553 (74e41dc) into master (aca14d6) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1553      +/-   ##
==========================================
- Coverage   71.56%   71.55%   -0.01%     
==========================================
  Files         205      205              
  Lines        6294     6296       +2     
==========================================
+ Hits         4504     4505       +1     
- Misses       1790     1791       +1     
Impacted Files Coverage Δ
crates/allocator/src/bump.rs 86.77% <0.00%> (-0.62%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@HCastano HCastano merged commit 34f9e8c into master Dec 16, 2022
@HCastano HCastano deleted the hc-fix-erc20-e2e-build branch December 16, 2022 23:29
HCastano added a commit that referenced this pull request Jan 23, 2023
The original PR for the ERC20 E2E tests had been sitting around a bit
long and didn't account for the extra `Result`. I should've merged
`master` into the PR before merging, haha.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants