-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin inter crate dependencies to specific version #1813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are always released together - you can consider switching to cargo workspace dependencies features and specify it (version, authors, etc.) in root Cargo.toml
.
Codecov Report
@@ Coverage Diff @@
## master #1813 +/- ##
==========================================
+ Coverage 52.14% 52.16% +0.01%
==========================================
Files 206 206
Lines 6656 6656
==========================================
+ Hits 3471 3472 +1
+ Misses 3185 3184 -1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It creates conflicts for #1835, but them is not hard to solve. I think we can start with pinning the version without a workspace, and when PR is ready switch to the workspace approach
Raised by @deuszx.
Currently dependencies between the
ink
crates are specified with a range i.e.4.2.0
which means>= 4.2.0, <5.0
.This means that when we released
4.2.1
recently, and contracts with anink
dependency of4.2.0
could pull in the new versions sub crates.This PR pins the versions of the inter-crate dependencies of all the
ink
crates, since they are always released together.