Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin inter crate dependencies to specific version #1813

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

ascjones
Copy link
Collaborator

Raised by @deuszx.

Currently dependencies between the ink crates are specified with a range i.e. 4.2.0 which means >= 4.2.0, <5.0.

This means that when we released 4.2.1 recently, and contracts with an ink dependency of 4.2.0 could pull in the new versions sub crates.

This PR pins the versions of the inter-crate dependencies of all the ink crates, since they are always released together.

Copy link

@deuszx deuszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are always released together - you can consider switching to cargo workspace dependencies features and specify it (version, authors, etc.) in root Cargo.toml.

@ascjones
Copy link
Collaborator Author

ascjones commented Jun 16, 2023

If they are always released together - you can consider switching to cargo workspace dependencies features and specify it (version, authors, etc.) in root Cargo.toml.

Good idea. I think @HCastano was investigating this at some point but not sure how far he got.

Issue: #1814

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #1813 (3c33996) into master (14c850c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1813      +/-   ##
==========================================
+ Coverage   52.14%   52.16%   +0.01%     
==========================================
  Files         206      206              
  Lines        6656     6656              
==========================================
+ Hits         3471     3472       +1     
+ Misses       3185     3184       -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It creates conflicts for #1835, but them is not hard to solve. I think we can start with pinning the version without a workspace, and when PR is ready switch to the workspace approach

@ascjones ascjones merged commit e2634dd into master Jul 17, 2023
@ascjones ascjones deleted the aj/fix-versions-in-ink-crate branch July 17, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants